On Thu, Dec 27, 2018 at 11:12:25AM +0100, Geert Uytterhoeven wrote: > Hi Shimoda-san, > > Thanks for the report! > > CC Will (commit author), Arnd (compiler collective). > > On Thu, Dec 27, 2018 at 2:58 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > > From: Geert Uytterhoeven, Sent: Wednesday, December 26, 2018 8:06 PM > > > I have pushed renesas-drivers-2018-12-26-v4.20 to > > > https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git > > > > > > This tree is meant to ease development of platform support and drivers > > > for Renesas ARM SoCs. It is created by merging (a) the for-next branches > > > of various subsystem trees and (b) branches with driver code submitted > > > or planned for submission to maintainers into the development branch of > > > Simon Horman's renesas.git tree. > > > > > > Today's version is based on renesas-devel-20181220-v4.20-rc7. > > > > I built this version with "gcc version 5.2.1 20151005 (Linaro GCC 5.2-2015.11-1)", > > and then the following build error happened: > > > > AS arch/arm64/kernel/head.o > > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S: Assembler messages: > > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')' > > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')' > > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')' > > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: unexpected characters following instruction at operand 2 -- `mov x2,#(2)|(2U<<(8))' > > > > This error seems to cause the commit 66f16a24512f ("arm64: smp: Rework early feature mismatched detection"). > > And if I modified the code as following, the build error disappeared: > > > > --- > > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h > > index 18955618..e9b9cee 100644 > > --- a/arch/arm64/include/asm/smp.h > > +++ b/arch/arm64/include/asm/smp.h > > @@ -30,7 +30,7 @@ > > #define CPU_PANIC_KERNEL (3) > > > > #define CPU_STUCK_REASON_52_BIT_VA (1U << CPU_STUCK_REASON_SHIFT) > > -#define CPU_STUCK_REASON_NO_GRAN (2U << CPU_STUCK_REASON_SHIFT) > > +#define CPU_STUCK_REASON_NO_GRAN (UL(2) << CPU_STUCK_REASON_SHIFT) > > > > #ifndef __ASSEMBLY__ > > --- > > > > So, I think we have to fix this, but what do you think? > > # I don't know why the line 812 doesn't cause the build error, > > # but the line 824 causes the build error though... I'm about to queue a flavour of: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-December/622858.html to address this. Cheers, Will
