Hi Niklas, > That should have been rate :-) To elaborate a bit more: > > The patch is different from v1 as a different approach to solve the > issue have been found. Instead of only ignoring the first row of the > list of possible settings when selecting which divider to use also > ignore it when examining which state the hardware is in. That is the > driver is no longer aware the first row exists with this patch. > > This was in v1 not possible as the first row might be a state the > bootloader left the hardware in and then the clock failed to register as > it would need to update its own state to match the hardware. > > As the driver needed to know about the state the hardware was in when > probing but not use it when selecting a divider the more complex v1 was > needed. When selecting a divider we wish for it to select the second > option for the divider value '4' when running on a SoC which needs the > quirk. > > With v2 which depends on [1] this is not needed as the clock driver now > sets a know state when registering the clock so this patch can be made > much simpler by simply 'removing' the first row from all operations. Thanks for the elaboration. I still think the above is the way to go and I still wonder a little why it was implemented differently beforehand. > > Hmm, why didn't you add it to the series then? > > Since it is unrelated to this series I thought it best to post it as a > separate patch as I think it has value to create a known starting state > disregarding where this series ends up :-) Yes, can be argued. Thanks, Wolfram
Attachment:
signature.asc
Description: PGP signature
