Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Monday, November 12, 2018 6:08 PM
>
> Hi Shimoda-san,
>
> On Mon, Nov 12, 2018 at 9:53 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > From: Geert Uytterhoeven, Sent: Monday, November 12, 2018 5:19 PM
> > > On Mon, Nov 12, 2018 at 8:24 AM Yoshihiro Shimoda
> > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
<snip>
> > @@ -770,7 +768,8 @@ static int ipmmu_of_xlate(struct device *dev,
> > struct of_phandle_args *spec)
> > {
> > /* For R-Car Gen3 use a white list to opt-in slave devices */
> > - if (soc_device_match(soc_rcar_gen3) && !ipmmu_slave_whitelist(dev))
> > + if (!soc_device_match(soc_rcar_gen3_blacklist) &&
> > + !ipmmu_slave_whitelist(dev))
> > return -ENODEV;
>
> Ah, this has the side effect of applying ipmmu_slave_whitelist() on R-Car
> Gen2, too, which is probably not what we want?
Oops! You're correct. The current code behavior is:
- Gen2 doesn't use any whitelist.
- Gen3 uses the whitelist.
If we apply this my patch above:
- Gen2 and Gen3 use the whitelist anyway.
This is not our expected, so I think we keep to use the current style.
# Note that my first suggestion [1] also broke the code because
# r8a7795 ES2.0 or older and r8a7796 don't use the whitelist...
#
# [1] https://www.spinics.net/lists/linux-renesas-soc/msg35048.html
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
