Re: [PATCH/RFC] iommu/ipmmu-vmsa: R-Car M3-N/V3H/E3 AVB whitelist prototype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Magnus,

Thanks for your patch!

On Sun, Oct 21, 2018 at 7:56 PM Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
> From: Magnus Damm <damm@xxxxxxxxxxxxx>
>
> For testing purpose enable IPMMU for Ethernet-AVB on R-Car M3-N/V3H/E3.
>
> Not for upstream merge.
>
> Not-Yet-Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>
> ---
>
>  Applies on top of renesas-devel-20181019-v4.19-rc8
>
>  drivers/iommu/ipmmu-vmsa.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> --- 0001/drivers/iommu/ipmmu-vmsa.c
> +++ work/drivers/iommu/ipmmu-vmsa.c     2018-10-22 02:46:30.139880557 +0900
> @@ -756,6 +756,10 @@ static int ipmmu_init_platform_device(st
>
>  static bool ipmmu_slave_whitelist(struct device *dev)
>  {
> +       /* R-Car M3-N/V3H/E3 Ethernet-AVB */
> +       if (!strcmp(dev_name(dev), "e6800000.ethernet"))
> +               return true;

I'm afraid the whitelisting doesn't work that way: with the above check, it will
be enabled on all R-Car Gen3 SoCs.

> +
>         /* By default, do not allow use of IPMMU */
>         return false;
>  }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux