Hi Kieran,
On Fri, Nov 02, 2018 at 12:27:11PM +0000, Kieran Bingham wrote:
> Hi Niklas, Sakari
>
> On 23/08/2018 14:25, Niklas Söderlund wrote:
> > From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > include/media/v4l2-subdev.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index 5acaeeb9b3cacefa..ac1f7ee4cdb978ad 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -349,12 +349,21 @@ struct v4l2_mbus_frame_desc_entry {
> >
> > #define V4L2_FRAME_DESC_ENTRY_MAX 4
> >
> > +enum {
> > + V4L2_MBUS_FRAME_DESC_TYPE_PLATFORM,
> > + V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL,
> > + V4L2_MBUS_FRAME_DESC_TYPE_CCP2,
> > + V4L2_MBUS_FRAME_DESC_TYPE_CSI2,
>
> Does this need to be extended to differentiate CSI2 DPHY/CPHY as has
> been done in the v4l2_mbus_config structures?
I'd say no; the PHY isn't really relevant at this level. The configuration
from fwnode should suffice.
--
Regards,
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
