RE: [PATCH 3/7] ARM: dts: r8a77470: Add USB PHY DT support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju-san,

> From: Biju Das, Sent: Monday, October 29, 2018 6:15 PM
> > -----Original Message-----
> > From: Yoshihiro Shimoda
> > Sent: 29 October 2018 08:42
> >
> > Hi Biju-san,
> >
> > > From: Biju Das, Sent: Thursday, October 25, 2018 10:57 PM
> > >
> > > Define the r8a77470 generic part of the USB PHY device node.
> > >
> > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > ---
> > > This patch is tested against renesas-devel
> >
> > Thank you for the patch!
> >
> > <snip>
> > > +		usbphy1: usb-phy@e6598100 {
> > > +			compatible = "renesas,usb-phy-r8a77470",
> > > +				     "renesas,rcar-gen2-usb-phy";
> > > +			reg = <0 0xe6598100 0 0x100>,
> > > +			      <0 0xee0c0200 0 0x118>;
> > > +			#address-cells = <1>;
> > > +			#size-cells = <0>;
> > > +			clocks = <&cpg CPG_MOD 706>, <&cpg CPG_MOD
> > 705>;
> > > +			clock-names = "usbhs", "usb20_host";
> > > +			status = "disabled";
> 
> 'status = "disabled"'.

Oops! I overlooked this line...

> > > +			resets = <&cpg 706>, <&cpg 705>;
> > > +			power-domains = <&sysc
> > R8A77470_PD_ALWAYS_ON>;
> > > +
> > > +			usb1: usb-channel@0 {
> > > +				reg = <0>;
> > > +				#phy-cells = <1>;
> > > +			};
> > > +		};
> >
> > I think this usbphy1 has to have 'status = "disabled"'.
> 
> It is already disabled please see above.

Indeed.
However, I prefer that properties order of both usbphy0 and usbphy1
are the same because it improves readability.

Best regards,
Yoshihiro Shimoda


> Regards,
> Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux