Hi Marek, On Sat, Oct 27, 2018 at 06:34:10PM +0200, Marek Vasut wrote: > The eMMC card has two supplies, VCC and VCCQ. The VCC supplies the NAND > array and the VCCQ supplies the bus. On this particular board, the VCC is > connected to 3.3V rail, while the VCCQ is connected to 1.8V rail. Adjust > the pinmux to match the bus, which is always operating in 1.8V mode. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> Thanks for this! I think Olof (and thus, Simon ;)) will be happy if those two patches are merged. Other than that, I think we should remove sdhi2_pins_uhs then because it is the same as sdhi2_pins. And then use later "pinctrl-1 = <&sdhi2_pins>;". So, basically the same phandles for both pinctrls. We can re-add the second one when we need it. > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > --- > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > index 7d3d866a0063..d9a309b28fcf 100644 > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -602,7 +602,7 @@ > sdhi2_pins: sd2 { > groups = "sdhi2_data8", "sdhi2_ctrl", "sdhi2_ds"; > function = "sdhi2"; > - power-source = <3300>; > + power-source = <1800>; > }; > > sdhi2_pins_uhs: sd2_uhs { > -- > 2.17.1 >
Attachment:
signature.asc
Description: PGP signature