CC Marc, Eduardo On Tue, Oct 2, 2018 at 2:56 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On 10/02/2018 02:06 AM, Cao Van Dong wrote: > > Dear Geert-san, > > > > Thanks for your comment! > > > >>> In __hwmon_device_register() function of hwmon.c, we have assigned 'dev' directly to 'hdev->parent'. > >>> Formerly, when registering the hwmon device, we pass NULL as the device. This is not affected. > >>> Recently, the developer has replaced the parameter NULL as the device by the actual device. > >> Do you know the commit ID of this recent change? > >> It's useful for review of your change, and to know to which versions your > >> patch should be backported. > > > > The commit ID of this recent change is"f6b6b52 thermal_hwmon: Pass the originating device down to hwmon_device_register_with_info". > > > If thermal doesn't want hwmon to use the thermal zone device, it should pass > the parent of that device as parameter. > > >>> This causes the "No sensors found" error. This patch is to fix this error. > >> On which platform do you see this failure? > >> Thanks again! > > > > This error is found on Gen2 Lager board v4.19-rc2 by RVC team. > > > > Some more details about the error would be useful. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds