Re: [PATCH] hwmon: Fix the 'No sensors found' error after replacing the parameter NULL by the actual device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Cao,

Thanks for your patch!

On Tue, Oct 2, 2018 at 10:35 AM Cao Van Dong <cv-dong@xxxxxxxxxxx> wrote:
> In __hwmon_device_register() function of hwmon.c, we have assigned 'dev' directly to 'hdev->parent'.
> Formerly, when registering the hwmon device, we pass NULL as the device. This is not affected.
> Recently, the developer has replaced the parameter NULL as the device by the actual device.

Do you know the commit ID of this recent change?
It's useful for review of your change, and to know to which versions your
patch should be backported.

> This causes the "No sensors found" error. This patch is to fix this error.

On which platform do you see this failure?
Thanks again!

> --- a/drivers/hwmon/hwmon.c
> +++ b/drivers/hwmon/hwmon.c
> @@ -610,7 +610,7 @@ __hwmon_device_register(struct device *dev, const char *name, void *drvdata,
>
>         hwdev->name = name;
>         hdev->class = &hwmon_class;
> -       hdev->parent = dev;
> +       hdev->parent = dev->parent;
>         hdev->of_node = dev ? dev->of_node : NULL;
>         hwdev->chip = chip;
>         dev_set_drvdata(hdev, drvdata);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux