On 09/12/2018 03:23 PM, Geert Uytterhoeven wrote:
>>>>> Document the R-Car V3{M|H} (R8A779{7|8}0) SoC in the Renesas TMU bindings;
>>>>> the TMU hardware in those is the Renesas standard 3-channel timer unit.
>>>>>
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>>>>
>>>> Thanks for your patch!
>>>>
>>>> Not all channels seem to be identical, but the driver just matches against
>>>> the "renesas,tmu" fallback?
>>>
>>> The only difference between TMUs is the input capture capability on the 3rd
>>> channel in each TMU -- that includes TCPR register and extra interrupt output
>>> TICPI<n> (perhaps has to do with 4th TMU IRQ?). The driver is blissfully unaware
>>> of this extra capability. :-)
>>>
>>>> In addition, the V3H TMU seems to differ from the TMU in other R-Car Gen3
>>>> variants?
>>>
>>> Yes, but they only differ in the number of channels capable of input capture.
>>>
>>>> How is this handled?
>>>
>>> Nohow. And I'm not sure we should care about this difference...
>>
>> It seems to me that the driver has the option of caring about the
>> difference, by matching on the soc-specific compat string, in future,
>> should it be so desired.
>>
>> So this patch seems find to me.
>>
>> Geert, am I missing something? Do you still have concerns?
>
> Matching on the SoC-specific compat strings is not sufficient, as the actual
> TMU instances in the same SoC are not identical.
ACK.
But the TMUs having the external clock signel seem upwardly compatible with
those TMUs that don't have it.
> Please check Section 80.1.1 "Features".
>
> The differences are in the number of clock inputs. As these are not the plain
> clocks, but core clocks + a postdivider,
Post-divider is controlled by TCR (per channel) and it doesn't get used for the
external clock.
> perhaps this can be handled by using
> clock-names like "div4", "div16", "div64" etc.?
No, you're misunderstanding things.
> I haven't checked the relation to register bits yet.
And now? :-)
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
