On 09/10/2018 05:24 PM, Geert Uytterhoeven wrote: >> Document the R-Car V3{M|H} (R8A779{7|8}0) SoC in the Renesas TMU bindings; >> the TMU hardware in those is the Renesas standard 3-channel timer unit. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > Thanks for your patch! > > Not all channels seem to be identical, but the driver just matches against > the "renesas,tmu" fallback? The only difference between TMUs is the input capture capability on the 3rd channel in each TMU -- that includes TCPR register and extra interrupt output TICPI<n> (perhaps has to do with 4th TMU IRQ?). The driver is blissfully unaware of this extra capability. :-) > In addition, the V3H TMU seems to differ from the TMU in other R-Car Gen3 > variants? Yes, but they only differ in the number of channels capable of input capture. > How is this handled? Nohow. And I'm not sure we should care about this difference... > Gr{oetje,eeting}s, > > Geert MBR, Sergei