RE: [PATCH v4] clk: renesas: cpg-mssr: Add R7S9210 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Monday, September 10, 2018 1, Geert Uytterhoeven wrote:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in clk-renesas-for-v4.20.

Thank you!

Now that I have a clock, I can go ahead and submit a Device Tree.
However, I still don't have a solution for my OSTM timer driver when 
using this new clock driver architecture.

Should I remove the ostm entries in r7s9210_mod_clks[] before you queue 
it up?????



> One possible area for improvement is removing the unused entries in the
> module clocks part of the priv->clks[] array:
> 
> +       .num_hw_mod_clks = 11 * 32, /* includes STBCR0 which doesn't exist
> */
> 
> Due to having 8-bit instead of 32-bit registers, 11 * 24 entries are not
> used.
> Fixing that means adding more checks in several functions, though, so I
> don't know if you want to go that far...

That's basically why I didn't touch it. I didn't see any big benefit 
from a system resource point of view.


Chris





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux