On Thu, Aug 30, 2018 at 02:29:02PM +0200, Geert Uytterhoeven wrote:
> On Fri, Aug 24, 2018 at 12:50 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > Add USB2.0 phy and host (EHCI/OHCI) device nodes on RZ/G2M SoC dtsi.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 73 +++++++++++++++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > index cd204f5..a794089 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
>
> > + ehci0: usb@ee080100 {
> > + compatible = "generic-ehci";
> > + reg = <0 0xee080100 0 0x100>;
> > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 703>;
> > + phys = <&usb2_phy0>;
> > + phy-names = "usb";
> > + companion= <&ohci0>;
>
> Please insert a space before the "=".
I fixed that by adding the update to your fixup patch for many similar
problems. Let me know if pain persists after I've pushed the devel branch.
>
> > + power-domains = <&sysc 32>;
> > + resets = <&cpg 703>;
> > + status = "disabled";
> > + };
> > +
> > + ehci1: usb@ee0a0100 {
> > + compatible = "generic-ehci";
> > + reg = <0 0xee0a0100 0 0x100>;
> > + interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 702>;
> > + phys = <&usb2_phy1>;
> > + phy-names = "usb";
> > + companion= <&ohci1>;
>
> Likewise.
>
> > + power-domains = <&sysc 32>;
> > + resets = <&cpg 702>;
> > + status = "disabled";
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
