Hi Fabrizio, (Usually the DT patch goes before the driver patch) On Thu, Aug 23, 2018 at 3:08 PM Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> wrote: > RZ/G2 devices don't have clkp2, therefore this commit adds a > generic compatible string for them to allow for proper checking > during probe. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > Signed-off-by: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/net/can/rcar/rcar_can.c > +++ b/drivers/net/can/rcar/rcar_can.c > @@ -27,6 +27,7 @@ > > #define RCAR_SUPPORTED_CLOCKS (BIT(CLKR_CLKP1) | BIT(CLKR_CLKP2) | \ > BIT(CLKR_CLKEXT)) > +#define RZG2_SUPPORTED_CLOCKS (BIT(CLKR_CLKP1) | BIT(CLKR_CLKEXT)) > > /* Mailbox configuration: > * mailbox 60 - 63 - Rx FIFO mailboxes > @@ -933,6 +934,10 @@ static const struct of_device_id rcar_can_of_table[] __maybe_unused = { > .compatible = "renesas,rcar-gen3-can", > .data = (void *)RCAR_SUPPORTED_CLOCKS, > }, > + { > + .compatible = "renesas,rzg-gen2-can", > + .data = (void *)RZG2_SUPPORTED_CLOCKS, > + }, > { } I think this patch is not needed, cfr. my reply to the first^H^H^H^H^Hthird patch in your series. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds