Hi Wolfram On Wed, Jul 25, 2018 at 9:35 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Add the nodes to enable SATA. Note that MD12 (SW12-7) must be switched > off for that to work. Thanks for your patch! > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts > @@ -176,6 +185,11 @@ > }; > }; > > + /* MD12 (SW12-7) must be set 'Off' which is not the default! */ Weird indentation? Either drop the indentation, or move the comment inside the &sata node? > +&sata { > + status = "okay"; > +}; > + > &usb2_phy2 { > pinctrl-0 = <&usb2_pins>; > pinctrl-names = "default"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds