Hi Wolfram, On 2018-07-24 13:26:34 +0200, Wolfram Sang wrote: > On Tue, Jul 17, 2018 at 04:52:15PM +0200, Niklas Söderlund wrote: > > When tuning each tap is issued CMD19 twice and the result of both runs > > recorded in host->taps. If the result is different between the two runs > > the wrong sampling clock position was selected. Fix this by merging the > > two runs and only keep the result for each tap if it was good in both > > sets. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > So, I tested this patch without having patch 2 applied and it worked: > > Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > Ulf, I think patches 1 & 3 are good and should be applied to 4.18 with > stable attached. I have collected all tags and broken out 1 and 3 to a v4 of this series for easy consumption for either you or Ulf. And I'm working on updating 2 and 4. > > And I wonder if it was easier if I'd send you pull requests now that we > are working with even more developers on SDHI? Simon, Niklas, what do > you think? > For me this approach would be great but as Simon points out maybe Ulf have a different idea. If you end up collecting and sending pull requests can you provide a public branch of the patches you have sent PR for so I can base my work upon that to avoid potential merge conflicts? -- Regards, Niklas Söderlund
