Hi Sergei, Thanks for your reply! On Thu, Jul 19, 2018 at 11:32 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Hello! > > On 07/19/2018 02:51 PM, Magnus Damm wrote: > >> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> >> According to the data sheet the Ethernet-AVB hardware in R-Car Gen3 >> and R-Car Gen2 SoCs do not support half duplex operation. So update >> the driver to mark 100Mbit HDX as unsupported. > > What about 1000Mbit HDX? For Twister Pair I believe 10 and 100 Mbps come in HDX and FDX flavors while 1 Gbps is HDX-only. https://en.wikipedia.org/wiki/Ethernet_over_twisted_pair >> Not-Yet-Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> --- >> >> Written on top of renesas-drivers-2018-07-17-v4.18-rc5 >> >> drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> --- 0001/drivers/net/ethernet/renesas/ravb_main.c >> +++ work/drivers/net/ethernet/renesas/ravb_main.c 2018-07-19 19:18:38.210607110 +0900 >> @@ -1066,8 +1066,8 @@ static int ravb_phy_init(struct net_devi >> netdev_info(ndev, "limited PHY to 100Mbit/s\n"); >> } >> >> - /* 10BASE is not supported */ >> - phydev->supported &= ~PHY_10BT_FEATURES; >> + /* Nether 10BASE nor half duplex is supported */ > > Neither. s/is/are/? > >> + phydev->supported &= ~(PHY_10BT_FEATURES | SUPPORTED_100baseT_Half); > > I think you missed SUPPORTED_1000baseT_Half. Perhaps so, but in reality all our boards use a PHY with Twisted Pair cables so SUPPORTED_1000baseT_Half doesn't exist in reality. That aside, I suspect the PHY layer is designed to support more than just Ethernet-over-TP so that's the reason for that particular constant and all the other stuff in phy.h. > [garbage skipped] You mean the rest of the driver? =) Cheers, / magnus
