Hi Niklas, On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> wrote: > Hi Magnus, > > Thanks for your patch. > > On 2018-07-19 20:19:50 +0900, Magnus Damm wrote: >> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> >> Browsing the DTS for all the R-Car SoCs with similar part numbers >> makes my head hurt, so to improve the user friendliness of the >> DTS code base include R-Car product name in each DTSI file. >> >> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> --- >> >> Based on renesas-drivers-2018-07-17-v4.18-rc5 >> >> arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 +- >> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +- >> 8 files changed, 8 insertions(+), 8 deletions(-) >> >> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi >> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900 >> @@ -1,6 +1,6 @@ >> // SPDX-License-Identifier: GPL-2.0 >> /* >> - * Device Tree Source for the r8a7795 ES1.x SoC >> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC > > I'm just curies why do you append a extra 0 to the part number here and > for M3-W? Other then I think this change is good and will help me as > well to map part number to product name :-) Good question! I should probably have mentioned in the patch description that the names and part numbers come from the file Documentation/devicetree/bindings/arm/shmobile.txt. Thanks for the feedback! Cheers, / magnus