On Wed, Jul 11, 2018 at 06:33:19PM +0200, Wolfram Sang wrote:
> EINVAL is very generic, use ENOTSUPP in case the gpiochip does not
> provide this function. While removing the assignment from the 'status'
> variable, use better indentation in the declaration block.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> ---
>
> I got puzzled by the EINVAL until I found out that gpio-rcar simply does not
> implement it.
>
> @Geert: any reason gpio-rcar is missing it? I would need it for the
> i2c-gpio-fault-injector.
>
> drivers/gpio/gpiolib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index e11a3bb03820..18719f64e80b 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -210,15 +210,15 @@ static int gpiochip_find_base(int ngpio)
> */
> int gpiod_get_direction(struct gpio_desc *desc)
> {
> - struct gpio_chip *chip;
> - unsigned offset;
> - int status = -EINVAL;
> + struct gpio_chip *chip;
> + unsigned offset;
> + int status;
>
> chip = gpiod_to_chip(desc);
> offset = gpio_chip_hwgpio(desc);
>
> if (!chip->get_direction)
> - return status;
> + return -ENOTSUPP;
>
> status = chip->get_direction(chip, offset);
> if (status > 0) {
> --
> 2.11.0
>
