Hi Vinod, On Tuesday, 3 July 2018 09:20:08 EEST Vinod wrote: > On 03-07-18, 08:49, Laurent Pinchart wrote: > > Hi Morimoto-san, > > > > Thank you for the patch. > > > > On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote: > > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > A commit message would be nice :-) > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > --- > > > > > > drivers/dma/sh/rcar-dmac.c | 18 +++++++----------- > > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c > > > index 79d14af..322e57b 100644 > > > --- a/drivers/dma/sh/rcar-dmac.c > > > +++ b/drivers/dma/sh/rcar-dmac.c > > > @@ -1,14 +1,10 @@ > > > -/* > > > - * Renesas R-Car Gen2 DMA Controller Driver > > > - * > > > - * Copyright (C) 2014 Renesas Electronics Inc. > > > - * > > > - * Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > - * > > > - * This is free software; you can redistribute it and/or modify > > > - * it under the terms of version 2 of the GNU General Public License as > > > - * published by the Free Software Foundation. > > > - */ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +// > > > +// Renesas R-Car Gen2 DMA Controller Driver > > > +// > > > +// Copyright (C) 2014 Renesas Electronics Inc. > > > +// > > > +// Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > I think the preferred comment style, accordingly to what other drivers do, > > is > > > > // SPDX-License-Identifier: GPL-2.0 > > /* > > > > * Renesas R-Car Gen2 DMA Controller Driver > > * > > * Copyright (C) 2014 Renesas Electronics Inc. > > * > > * Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > */ > > And Linus said this https://lkml.org/lkml/2017/11/25/133 > > So lets keep C99 style as Morimoto-San proposed. > > And high time, this should be documented :) As mentioned before, while I certainly prefer the traditional C-style comments, I ultimately let driver authors decide. What matters most in my opinion is consistency, mixing styles in the same driver just makes the code harder to read. What matters in the end is how easy reading the code will be, and until the majority of kernel developers get used to the C++ comment style, no matter what Linus' personal preference is, // will be an annoyance. -- Regards, Laurent Pinchart
