Hi Morimoto-san, Thank you for the patch. On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> A commit message would be nice :-) > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > --- > drivers/dma/sh/rcar-dmac.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c > index 79d14af..322e57b 100644 > --- a/drivers/dma/sh/rcar-dmac.c > +++ b/drivers/dma/sh/rcar-dmac.c > @@ -1,14 +1,10 @@ > -/* > - * Renesas R-Car Gen2 DMA Controller Driver > - * > - * Copyright (C) 2014 Renesas Electronics Inc. > - * > - * Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > - * > - * This is free software; you can redistribute it and/or modify > - * it under the terms of version 2 of the GNU General Public License as > - * published by the Free Software Foundation. > - */ > +// SPDX-License-Identifier: GPL-2.0 > +// > +// Renesas R-Car Gen2 DMA Controller Driver > +// > +// Copyright (C) 2014 Renesas Electronics Inc. > +// > +// Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> I think the preferred comment style, accordingly to what other drivers do, is // SPDX-License-Identifier: GPL-2.0 /* * Renesas R-Car Gen2 DMA Controller Driver * * Copyright (C) 2014 Renesas Electronics Inc. * * Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> */ Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > #include <linux/delay.h> > #include <linux/dma-mapping.h> -- Regards, Laurent Pinchart
