Hi Michel, On Thu, Jun 14, 2018 at 1:03 PM Michel Pollet <michel.pollet@xxxxxxxxxxxxxx> wrote: > This provides a clock driver for the Renesas R09A06G032. > This uses a structure derived from both the RCAR gen2 driver as well as > the renesas-cpg-mssr driver. > > Signed-off-by: Michel Pollet <michel.pollet@xxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/drivers/clk/renesas/r9a06g032-clocks.c > +static int __init r9a06g032_clocks_probe(struct platform_device *pdev) > +{ [...] > + error = of_clk_add_provider(np, of_clk_src_onecell_get, &clocks->data); > + if (error) > + return error; > + > + error = devm_add_action_or_reset( > + dev, r9a06g032_clocks_del_clk_provider, np); > + > + return error; This could just be "return devm_add_action_or_reset(...);". Queuing in clk-renesas-for-v4.19 with the above small change. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds