Hi Geert
On 06/06/18 07:34, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Wed, Jun 6, 2018 at 1:34 AM, Kieran Bingham
> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
>> Provide device tree binding documentation for the MAX9286 Quad GMSL
>> deserialiser.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
Thanks for your review,
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/max9286.txt
>> @@ -0,0 +1,75 @@
>> +* Maxim Integrated MAX9286 GMSL Quad 1.5Gbps GMSL Deserializer
>> +
>> +Required Properties:
>> + - compatible: Shall be "maxim,max9286"
>> +
>> +The following required properties are defined externally in
>> +Documentation/devicetree/bindings/i2c/i2c-mux.txt:
>> + - Standard I2C mux properties.
>> + - I2C child bus nodes.
>> +
>> +A maximum of 4 I2C child nodes can be specified on the MAX9286, to
>> +correspond with a maximum of 4 input devices.
>> +
>> +The device node must contain one 'port' child node per device input and output
>> +port, in accordance with the video interface bindings defined in
>> +Documentation/devicetree/bindings/media/video-interfaces.txt. The port nodes
>> +are numbered as follows.
>> +
>> + Port Type
>> + ----------------------
>> + 0 sink
>> + 1 sink
>> + 2 sink
>> + 3 sink
>> + 4 source
>
> I assume the source and at least one sink are thus mandatory?
Yes, that would make some sense :D
> Would it make sense to use port 0 for the source?
> This would simplify extending the binding to devices with more input
> ports later.
I think that sounds like a reasonable suggestion too.
I'm not sure how much extending this device (family) would get yet, but it
doesn't hurt to future proof.
--
Regards
Kieran
> Gr{oetje,eeting}s,
>
> Geert
>
