> > For it to be unsafe, i think that would mean phylib would need to call
> > back into the MAC driver? The only way that could happen is via the
> > adjust_link call. And that will deadlock, since it takes the same
> > lock.
> >
> > Or am i/we missing something?
>
> It doesn't take any locks currently, only patches #3/#6 makes it do so...
Ah, yes.
You should not be holding any spinlocks when calling into phylib.
It does its own locking, which is mutex based.
The code in this patch is not touching the MAC, so looks safe to me.
Andrew
