On 05/24/2018 07:44 PM, Andrew Lunn wrote: >>>>> The change fixes a sleep in atomic context issue, which can be >>>>> always triggered by running 'ethtool -r' command, because >>>>> phy_start_aneg() protects phydev fields by a mutex. >> >> You don't say that *not* grabbing the spinlock is safe... > > For it to be unsafe, i think that would mean phylib would need to call > back into the MAC driver? The only way that could happen is via the > adjust_link call. And that will deadlock, since it takes the same > lock. > > Or am i/we missing something? It doesn't take any locks currently, only patches #3/#6 makes it do so... > Andrew MBR, Sergei
