On Wed, May 16, 2018 at 11:59:32AM +0300, Sergei Shtylyov wrote: > Hello! > > On 5/16/2018 10:54 AM, Simon Horman wrote: > > > > Add support for the R-Car D3 (R8A77995) SoC to the LVDS encoder driver. > > > > > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> > > > --- > > > drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > > > index 3d2d3bb..58fb9f8 100644 > > > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > > > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > > > @@ -511,6 +511,11 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77970_info = { > > > .quirks = RCAR_LVDS_QUIRK_GEN2_PLLCR | RCAR_LVDS_QUIRK_GEN3_LVEN, > > > }; > > > +static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = { > > > + .gen = 3, > > > + .quirks = RCAR_LVDS_QUIRK_GEN3_LVEN, > > > +}; > > > > This new structure seems to be identical to rcar_lvds_r8a77970_info. > > Could we consolidate somehow? > > In my book, that one has 2 quirk flags. What tree are you looking at? True, my eyes seem to have deceived me.