Hi Kieran, Thank you for the patch. On Friday, 27 April 2018 19:57:22 EEST Kieran Bingham wrote: > The DU1 external dot clock is provided by the fixed frequency clock > generator X21, while the DU0 and DU3 clocks are provided by the > programmable Versaclock6 clock generator. > > Enable the clocks, and the HDMI encoder for the M3-N Salvator-XS, and > hook it up to the HDMI connector > > Based on patches from Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > --- > .../boot/dts/renesas/r8a77965-salvator-xs.dts | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts index > a83a00deed9e..dcf1849f1a67 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > @@ -19,3 +19,32 @@ > reg = <0x0 0x48000000 0x0 0x78000000>; > }; > }; > + > +&du { > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 721>, > + <&cpg CPG_MOD 727>, > + <&versaclock6 1>, > + <&x21_clk>, > + <&versaclock6 2>; > + clock-names = "du.0", "du.1", "du.3", "lvds.0", > + "dclkin.0", "dclkin.1", "dclkin.3"; You should remove the LVDS clock from here too. Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > +}; > + > +&hdmi0 { > + status = "okay"; > + > + ports { > + port@1 { > + reg = <1>; > + rcar_dw_hdmi0_out: endpoint { > + remote-endpoint = <&hdmi0_con>; > + }; > + }; > + }; > +}; > + > +&hdmi0_con { > + remote-endpoint = <&rcar_dw_hdmi0_out>; > +}; -- Regards, Laurent Pinchart