On Fri, Apr 20, 2018 at 10:06:03PM +0300, Sergei Shtylyov wrote:
> On 04/20/2018 12:58 PM, Simon Horman wrote:
>
> >> Define the generic R8A77980 part of the MMC0 (SDHI2) device node.
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >>
> >> ---
> >> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> ===================================================================
> >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> @@ -371,6 +371,18 @@
> >> dma-channels = <16>;
> >> };
> >>
> >> + mmc0: mmc@ee140000 {
> >
> > Please use sdhi2: sd@ee140000 for consistency with other SoCs
> > (I refereed to the r8a7795).
>
> Mmm... note that this controller has MMC signals (8 data bits, DS, no CD/WP),
> see manual v0.55. I think it's more correct to call it MMC0 (trken from the
> manual as well)...
Ok, point taken. I've applied this. But in general I would like the
dtsi files to be consistent where it makes sense.
