Hi Sergei,
On Wed, Apr 18, 2018 at 10:26 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> I've included the pin I/O voltage control into the R8A77970 PFC driver but
> it was incomplete because:
> - SH_PFC_PIN_CFG_IO_VOLTAGE pin flags weren't set properly;
> - sh_pfc_soc_info::ioctrl_regs wasn't set at all...
Thanks for your patch!
> Fixes: b92ac66a1819 ("pinctrl: sh-pfc: Add R8A77970 PFC support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Minor nit below...
> --- renesas-drivers.orig/drivers/pinctrl/sh-pfc/pfc-r8a77970.c
> +++ renesas-drivers/drivers/pinctrl/sh-pfc/pfc-r8a77970.c
> @@ -2382,18 +2384,33 @@ static const struct pinmux_cfg_reg pinmu
> { },
> };
>
> +enum ioctrl_regs {
> + IOCTRL30,
> + IOCTRL31,
> + IOCTRL32,
> + IOCTRL40,
Note for the future: unlike all other current pocctrl handling, IOCTRL32
is used to select between 2.5V and 3.3V (instead of 1.8V and 3.3V).
Handling that will require changes to the r8a77980_pin_to_pocctrl()
interface (add two output parameters returning supported voltages?).
> + IOCTRL40,
That's TDSEL, and thus not related to I/O voltage.
But I agree it should be saved during suspend/resume. ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
