On Tue, Apr 17, 2018 at 11:12:41AM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 17, 2018 at 5:50 AM, Mylène Josserand > <mylene.josserand@xxxxxxxxxxx> wrote: > > Move the assembly code for cluster cache enabling and resuming > > into an assembly file instead of having it directly in C code. > > > > Remove the CFLAGS because we are using the ARM directive "arch" > > instead. > > > > Signed-off-by: Mylène Josserand <mylene.josserand@xxxxxxxxxxx> > > --- > > arch/arm/mach-sunxi/Makefile | 4 +-- > > arch/arm/mach-sunxi/headsmp.S | 80 +++++++++++++++++++++++++++++++++++++++++ > > arch/arm/mach-sunxi/mc_smp.c | 82 +++---------------------------------------- > > 3 files changed, 85 insertions(+), 81 deletions(-) > > create mode 100644 arch/arm/mach-sunxi/headsmp.S > > I'm still not convinced about this whole "move ASM to separate > file" thing, especially now that you aren't actually adding any > sunxi-specific ASM code beyond a simple function call. > > Could you drop this for now? I'd really like to have this merged actually. There's a significant readibility improvement, so even if there's no particular functional improvement, I'd still call it a win. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
