Hi Rob, On 13 April 2018 19:06, Rob Herring: > On Tue, Apr 10, 2018 at 09:30:03AM +0100, Michel Pollet wrote: > > The Renesas RZ/N1 Family (Part #R9A06G0xx) has a multi-function system > > controller. This documents the node used to encapsulate it's sub > > drivers. > > > > Signed-off-by: Michel Pollet <michel.pollet@xxxxxxxxxxxxxx> > > --- > > .../bindings/mfd/renesas,rzn1-sysctrl.txt | 23 > ++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt > > > > diff --git > > a/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt > > b/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt > > new file mode 100644 > > index 0000000..9897f8f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt > > @@ -0,0 +1,23 @@ > > +DT bindings for the Renesas RZ/N1 System Controller > > + > > +== System Controller Node == > > + > > +The system controller node currently only hosts a single sub-node to > > +handle the rebooting of the CPU. Eventually it will host the clock > > +driver, SMP start handler, watchdog etc. > > Please submit a complete binding for the h/w block. > > Again, if the only reason you have sub nodes is to define compatible strings > and in turn enumerate drivers, then you don't need the nodes in DT. DT is > not the only way to instantiate drivers. I can't document it before I have the code. There is 0.000% chance of my clock driver for example to be upstreamed the way I would imagine making it -- in fact pretty much any other driver will have to be reworked to fit, so documenting bindings first is impossible. So, if I understand correctly, you are telling me to make a 'sysctrl' driver and use platform_device to instantiate my sub-drivers? Isn't that what machine files used to do? And they are now banned? Geert, any guidance here? > > Rob Thanks! Michel Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
