Hello! On 04/16/2018 04:02 PM, Geert Uytterhoeven wrote: >> Add the pin I/O voltage level control to the R8A77980 PFC driver. > > Subject says r8a77970? Typo, I guess. :-) >> Loosely based on the original (and large) patch by Vladimir Barinov. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> >> >> --- >> drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 50 +++++++++++++++++++++++++++++++--- >> 1 file changed, 47 insertions(+), 3 deletions(-) >> >> Index: renesas-drivers/drivers/pinctrl/sh-pfc/pfc-r8a77980.c >> =================================================================== >> --- renesas-drivers.orig/drivers/pinctrl/sh-pfc/pfc-r8a77980.c >> +++ renesas-drivers/drivers/pinctrl/sh-pfc/pfc-r8a77980.c > > Ah, pfc-r8a77980.c it is. > >> @@ -2779,8 +2779,51 @@ static const struct pinmux_cfg_reg pinmu >> { }, >> }; >> >> +enum ioctrl_regs { >> + IOCTRL30, >> + IOCTRL31, >> + IOCTRL32, >> +}; >> + >> +static const struct pinmux_ioctrl_reg pinmux_ioctrl_regs[] = { >> + [IOCTRL30] = { 0xe6060380, }, >> + [IOCTRL31] = { 0xe6060384, }, >> + [IOCTRL32] = { 0xe6060388, }, >> + { /* sentinel */ }, > > However, r8a77980 has 4 IOCTRL3x registers (r8a77970 has three)? I thought that since we don't change it, no need to list it for save/restore either. I was wrong? > Something is wrong: which SoC source file is this patch for? R8A77980. > Gr{oetje,eeting}s, > > Geert MBR, Sergei