Hello!
On 04/13/2018 05:10 PM, Wolfram Sang wrote:
> Whitelisting every ES version does not scale. So, we whitelist whole
> SoCs independent of ES version. If we need specific handling for an ES
> version, we put it to the front, so it will be matched first.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> Tested-by: Nguyen Viet Dung <dung.nguyen.aj@xxxxxxxxxxx>
> ---
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> index a02fab89e25e..4b275225aa9d 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -272,12 +272,15 @@ static const struct tmio_mmc_dma_ops renesas_sdhi_internal_dmac_dma_ops = {
> * implementation as others may use a different implementation.
> */
> static const struct soc_device_attribute gen3_soc_whitelist[] = {
> + /* specific ones */
> { .soc_id = "r8a7795", .revision = "ES1.*",
> .data = (void *)BIT(SDHI_INTERNAL_DMAC_ONE_RX_ONLY) },
> - { .soc_id = "r8a7795", .revision = "ES2.0" },
> { .soc_id = "r8a7796", .revision = "ES1.0",
> .data = (void *)BIT(SDHI_INTERNAL_DMAC_ONE_RX_ONLY) },
> - { .soc_id = "r8a77995", .revision = "ES1.0" },
> + /* generic ones */
> + { .soc_id = "r8a7795" },
> + { .soc_id = "r8a7796" },
> + { .soc_id = "r8a77995" },
Could you use a tab for indentation of the new lines?
Actually, it was on my TODO list (before the patch adding R8A77980 to the white
list)...
> { /* sentinel */ }
> };
>
MBR, Sergei
