Hello! On 04/06/2018 02:08 PM, Sergei Shtylyov wrote: > On R-Car gen3 SoCs the PCIe PHY has its own register region -- and I have > written a generic PHY driver for it, thus we need to add the corresponding > code in rcar_pcie_hw_init_gen3() and call devm_phy_optional_get() at the > driver's probing time, so that the existing R-Car gen3 device trees (not > having a PHY node) would still work (we only need to power up the PHY on > R-Car V3H). > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > --- > drivers/pci/host/pcie-rcar.c | 27 +++++++++++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > Index: pci/drivers/pci/host/pcie-rcar.c > =================================================================== > --- pci.orig/drivers/pci/host/pcie-rcar.c > +++ pci/drivers/pci/host/pcie-rcar.c [...] > @@ -916,6 +933,10 @@ static int rcar_pcie_get_resources(struc > struct resource res; > int err, i; > > + pcie->phy = devm_phy_optional_get(dev, "pcie"); > + if (IS_ERR(pcie->phy)) > + return PTR_ERR(pcie->phy); > + Forgot to update the bindings. Sigh... :-( [...] MBR, Sergei
