On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
>>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
>>> need to be kept powered when backup mode is enabled. Reflect this in
>>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
>>>
>>> The accessory power switch (SW23) is a toggle switch, hense specify
>>> "rohm,rstbmode-level".
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>> ---
>>> v2:
>>> - Add rohm,rstbmode-level.
>>> ---
>>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644
>>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>>> @@ -376,6 +376,8 @@
>>> #interrupt-cells = <2>;
>>> gpio-controller;
>>> #gpio-cells = <2>;
>>> + rohm,ddr-backup-power = <15>;
>>
>> Why not 0xf if those are all bit flags?
>
> Because it's a small number?
> Does it matter?
I think hex is preferable for the bit flags. Decimal makes one think it's something
else -- some magnitude, etc...
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
