On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi,
> CC Steve Twiss
>
> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>> one DA9063 and one DA9210 on Porter, the only difference from
>> the other boards is that DA9063 is at I2C address 0x5a rather
>> than 0x58 .
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/arch/arm/boot/dts/r8a7791-porter.dts
>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
>> @@ -354,10 +354,47 @@
>> clock-frequency = <400000>;
>> };
>>
>> +&i2c6 {
>> + status = "okay";
>> + clock-frequency = <100000>;
>> +
>> + pmic@5a {
>> + compatible = "dlg,da9063";
>
> Does it matter that this is a DA9063L ("Variant 6B")?
> Do we need a new compatible value, or can this be detected at runtime?
The driver detects it
da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)
Comparing the datasheets makes it obvious that 9063L is just a cut-down
version of 9063, with less LDOs and one less ADC. So I think we should
have extra compatible and have the driver restrict which LDOs can be
used with this smaller PMIC.
--
Best regards,
Marek Vasut
