Re: [PATCH 4/4] arm64: dts: r8a7795: Add PWM device nodes

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

Hello!

On 1/19/2016 3:18 PM, Ulrich Hecht wrote:

> From: Ryo Kodama <ryo.kodama.vz@xxxxxxxxxxx>
>
> Signed-off-by: Ryo Kodama <ryo.kodama.vz@xxxxxxxxxxx>
> Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@xxxxxxxxxxx>
> [uli: adapted to new MSTP clock scheme]
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>

[...]
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> index 265d12f..04661cf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -93,6 +93,15 @@
>   };
>   
>   &pfc {
> +	pwm1_pins: pwm1 {
> +		renesas,groups = "pwm1_a", "pwm1_b";

   Why both PWM1_A and PWM1_B? Aren't you supposed to select one?

> +		renesas,function = "pwm1";
> +	};
> +	pwm2_pins: pwm2 {
> +		renesas,groups = "pwm2_a", "pwm2_b";

   Same here...

> +		renesas,function = "pwm2";
> +	};
> +
>   	scif1_pins: scif1 {
>   		renesas,groups = "scif1_data_a", "scif1_ctrl";
>   		renesas,function = "scif1";
[...]

MBR, Sergei