On Tue, Jan 9, 2018 at 2:58 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > This will be needed when we want to create STOP conditions, too, later. > Create the needed fields and populate them for the GPIO case if the GPIO > is set to output. > > Tested-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Geert pointed out a bug in *_cansleep() so I have merged his fix for v4.15. Everything "should be smooth". > + /* FIXME: add proper flag instead of '0' once available */ > + if (gpiod_get_direction(bri->sda_gpiod) == 0) Yeah I should fix ... I suspect I need to do something kernel-wide to shape this up. Yours, Linus Walleij
