RE: [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Friday, January 05, 2018, Geert Uytterhoeven wrote:
> > +       {
> > +               .compatible = "renesas,usbhs-r7s72100",
> > +               .data = (void *)USBHS_TYPE_RZA1,
> > +       },
> 
> I think it suffices to drop the part above...
> 
> >         {
> >                 .compatible = "renesas,rcar-gen2-usbhs",
> >                 .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > @@ -488,6 +493,10 @@ static const struct of_device_id usbhs_of_match[] =
> {
> >                 .compatible = "renesas,rcar-gen3-usbhs",
> >                 .data = (void *)USBHS_TYPE_RCAR_GEN3,
> >         },
> > +       {
> > +               .compatible = "renesas,rza1-usbhs",
> > +               .data = (void *)USBHS_TYPE_RZA1,
> > +       },
> 
> ... and just let the driver match against the generic compatible value.
> But then you have to add "renesas,rza1-usbhs" to the DTS, too.

OK. I can do that.

I keep forgetting all the new/old DT rules.
I thought there was something about you always need a generic name and
also a device specific name.

I'm happy with just "renesas,rza1-usbhs".


> > --- /dev/null
> > +++ b/drivers/usb/renesas_usbhs/rza.c
> > @@ -0,0 +1,52 @@
> > +// SPDX-License-Identifier: GPL-1.0+
> 
> Not GPL-2.0?

Oops. Copy/paste error.


I'll submit a V3 of the series.


Thanks!

Chris





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux