Hi Chris,
On Fri, Jan 5, 2018 at 7:46 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> This patch adds the capability to support RZ/A1 SoCs.
>
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
Thanks for your patch!
> index c5289b3ecf8d..2abefd3d6050 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -480,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = {
> .compatible = "renesas,usbhs-r8a77995",
> .data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
> },
> + {
> + .compatible = "renesas,usbhs-r7s72100",
> + .data = (void *)USBHS_TYPE_RZA1,
> + },
I think it suffices to drop the part above...
> {
> .compatible = "renesas,rcar-gen2-usbhs",
> .data = (void *)USBHS_TYPE_RCAR_GEN2,
> @@ -488,6 +493,10 @@ static const struct of_device_id usbhs_of_match[] = {
> .compatible = "renesas,rcar-gen3-usbhs",
> .data = (void *)USBHS_TYPE_RCAR_GEN3,
> },
> + {
> + .compatible = "renesas,rza1-usbhs",
> + .data = (void *)USBHS_TYPE_RZA1,
> + },
... and just let the driver match against the generic compatible value.
But then you have to add "renesas,rza1-usbhs" to the DTS, too.
> --- /dev/null
> +++ b/drivers/usb/renesas_usbhs/rza.c
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-1.0+
Not GPL-2.0?
> +++ b/drivers/usb/renesas_usbhs/rza.h
> @@ -0,0 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
like here?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
