Hello Geert,
Thank you for your feedback.
> Subject: Re: [PATCH 5/6] pinctrl: sh-pfc: r8a7791: Add tpu groups and function
>
> Hi Fabrizio,
>
> On Thu, Dec 14, 2017 at 11:56 AM, Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > This patch adds tpu groups and function to r8a7743/r8a7791/r8a7793.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
>
> With the sort order fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
I'll send a v2 to fix the order.
Thanks,
Fab
>
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> > @@ -3892,6 +3892,32 @@ static const unsigned int sdhi2_wp_mux[] = {
> > SD2_WP_MARK,
> > };
> >
> > +/* - TPU -------------------------------------------------------------------- */
> > +static const unsigned int tpu_to0_pins[] = {
> > + RCAR_GP_PIN(6, 14),
> > +};
> > +static const unsigned int tpu_to0_mux[] = {
> > + TPU_TO0_MARK,
> > +};
> > +static const unsigned int tpu_to1_pins[] = {
> > + RCAR_GP_PIN(1, 17),
> > +};
> > +static const unsigned int tpu_to1_mux[] = {
> > + TPU_TO1_MARK,
> > +};
> > +static const unsigned int tpu_to2_pins[] = {
> > + RCAR_GP_PIN(1, 18),
> > +};
> > +static const unsigned int tpu_to2_mux[] = {
> > + TPU_TO2_MARK,
> > +};
> > +static const unsigned int tpu_to3_pins[] = {
> > + RCAR_GP_PIN(1, 24),
> > +};
> > +static const unsigned int tpu_to3_mux[] = {
> > + TPU_TO3_MARK,
> > +};
> > +
> > /* - SSI -------------------------------------------------------------------- */
> > static const unsigned int ssi0_data_pins[] = {
> > /* SDATA */
>
> Please use alphabetical sort order (also below).
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
[https://www2.renesas.eu/media/email/unicef_2017.jpg]
This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
