2017-12-18 22:01 GMT+09:00 Ulf Hansson <ulf.hansson@xxxxxxxxxx>: > On 18 December 2017 at 01:00, Wolfram Sang > <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: >> Not all archs define reads* and writes*. Switch to ioread*_rep and >> friends which is defined everywhere, so we can enable COMPILE_TEST after >> that. >> >> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > Thanks, applied for next! > > I put the patch in front of Yamada-san's patch that made it possible > to use COMPILE_TEST. Thus avoiding breaking bisecting. > >> --- >> >> So, I pushed this to buildbot on top of Yamada-san's patch series and there >> were no complaints, even with COMPILE_TEST enabled. I also did some tests on >> HW and checksuming huge files on SD cards still works. >> >> However, I am not sure about this mixture of read* and ioread* functions. Shall >> we convert maybe all of those? > > Yes, seems like a good idea. > > [...] > BTW, is ioread* preferred to read*? We need to eliminate the root cause. Other drivers using reads* cannot enable COMPILE_TEST for the same reason. Wolfram, Can you send a patch for sparc64? -- Best Regards Masahiro Yamada
