RE: [PATCH ] dt-bindings: PCI: rcar: Add device tree support for r8a7743

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks. I will send a V2 for fixing this.

Regards,
Biju

> -----Original Message-----
> From: geert.uytterhoeven@xxxxxxxxx [mailto:geert.uytterhoeven@xxxxxxxxx]
> On Behalf Of Geert Uytterhoeven
> Sent: 13 November 2017 19:11
> To: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Simon
> Horman <horms@xxxxxxxxxxxx>; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>; Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx>; linux-pci <linux-pci@xxxxxxxxxxxxxxx>;
> Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH ] dt-bindings: PCI: rcar: Add device tree support for
> r8a7743
>
> Hi Biju,
>
> On Mon, Nov 13, 2017 at 5:37 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller is
> > identical to the R-Car Gen2 family.
> >
> > No driver change is needed due to the fallback compatible value
> > "renesas,pcie-rcar-gen2".
> > Adding the SoC-specific compatible values here has three purposes:
> > 1. Document which SoCs have this hardware module, 2. Allow checkpatch
> > to validate compatible values.
> > 3. Allow the driver to support SoC specific implementations in future
> >    as necessary.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> With the below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > @@ -1,13 +1,15 @@
> >  * Renesas R-Car PCIe interface
> >
> >  Required properties:
> > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> > +           "renesas,pcie-r8a7779" for the R8A7779 SoC;
> >             "renesas,pcie-r8a7790" for the R8A7790 SoC;
> >             "renesas,pcie-r8a7791" for the R8A7791 SoC;
> >             "renesas,pcie-r8a7793" for the R8A7793 SoC;
> >             "renesas,pcie-r8a7795" for the R8A7795 SoC;
> >             "renesas,pcie-r8a7796" for the R8A7796 SoC;
> > -           "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> > +           "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> > +                                    RZ-G1 compatible device.
>
> RZ/G1
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But when
> I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux