Hi Biju, On Mon, Nov 13, 2017 at 5:37 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller > is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,pcie-rcar-gen2". > Adding the SoC-specific compatible values here has three purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. > 3. Allow the driver to support SoC specific implementations in future > as necessary. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> Thanks for your patch! With the below fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -1,13 +1,15 @@ > * Renesas R-Car PCIe interface > > Required properties: > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > + "renesas,pcie-r8a7779" for the R8A7779 SoC; > "renesas,pcie-r8a7790" for the R8A7790 SoC; > "renesas,pcie-r8a7791" for the R8A7791 SoC; > "renesas,pcie-r8a7793" for the R8A7793 SoC; > "renesas,pcie-r8a7795" for the R8A7795 SoC; > "renesas,pcie-r8a7796" for the R8A7796 SoC; > - "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > + "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or > + RZ-G1 compatible device. RZ/G1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds