Hi Chris,
On Wed, Oct 4, 2017 at 4:16 PM, Chris Brandt <Chris.Brandt@xxxxxxxxxxx> wrote:
> On Wednesday, October 04, 2017, Geert Uytterhoeven wrote:
>> > Required properties:
>> > - compatible
>> > - this shall be "renesas,r7s72100-ports".
>> > + this shall be "renesas,r7s72100-ports" for RZ/A1H and RZ/A1M or
>> > + "renesas,r7s72102-ports" for RZ/A1L
>>
>> Shouldn't you also document "renesas,r7s72101-ports" for RZ/A1M?
>
> I was wondering if you were going to ask for that.
:-)
> I put "for RZ/A1H and RZ/A1M" in the DT documentation, but if you
> prefer, I can also just add to pinctrl-rza1.c:
>
> static const struct of_device_id rza1_pinctrl_of_match[] = {
> {
> /* RZ/A1H */
> .compatible = "renesas,r7s72100-ports",
> .data = &rza1h_pmx_conf,
> },
> + {
> + /* RZ/A1M */
> + .compatible = "renesas,r7s72101-ports",
> + .data = &rza1h_pmx_conf,
> + }, {
> /* RZ/A1L */
> .compatible = "renesas,r7s72102-ports",
> .data = &rza1l_pmx_conf,
> },
> { }
> };
>
>
>
>> You could use "renesas,r7s72100-ports" as a fallback property for RZ/A1M,
>> though.
>
> Do you mean in the DT? Or in pinctrl-rza1.c?
I mean in DT, i.e.:
pinctrl: pin-controller@fcfe3000 {
compatible = "renesas,r7s72101-ports", "renesas,r7s72100-ports";
...
That way you don't have to extend the pinctrl driver.
>> BTW, is there a way to distinguish the various RZ/A1 SoCs at runtime?
>
> Sadly there is not.
>
> There is a unique ID number, but it is only accessible via JTAG
> externally.
>
> Internally, you would have to look for registers that don't exist (for
> the RZ/A1L). But for RZ/A1H vs RZ/A1M, the only actual difference is the
> amount of RAM, so you would have to do a set-and-test method on RAM.
If RZ/A1H and RZ/A1M differ in the amount of RAM only, I think you can
just consider them the same, though, and use the same DTS (assumed
the boot loader fills/corrects in the memory node).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
