Hi Dirk, On Tue, Aug 29, 2017 at 12:36 PM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote: > On 29.08.2017 11:44, Geert Uytterhoeven wrote: >> On Tue, Aug 29, 2017 at 11:15 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> >> wrote: >>> >>> But ZG and with this module clock #112 is still missing, no? >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?h=v4.9/rcar-3.5.8&id=aa7b99b06d280e4151e >>> >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?h=v4.9/rcar-3.5.8&id=a03bfd8abc9572800fb5043 >> >> >> The ZG bits in the FRQCRB register are documented to exist on R-Car D3 >> only. > > ... what contradicts > > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?h=v4.9/rcar-3.5.8&id=a03bfd8abc9572800fb5043 > > and the 3DGE module clock in e.g. MSTPSR1 which is documented for H3 and > M3-W, too, and Table 8.1a List of Clocks [R-Car H3] ZG -> 3DGE etc. That commit doesn't use CLK_TYPE_GEN3_ZG, but models ZG as PLL4/4, which matches the block diagram and the list of clocks. So that one is acceptable (modulo upstream (non)use of the 3DGE module?). Later, ZG is changed to use the non-documented bits, cfr. https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?h=v4.9/rcar-3.5.8&id=054863e7a5855be9b4652c588c140d49bede4dc4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
