Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thank you for the review!

On 10.07.2017 16:09, Laurent Pinchart wrote:
Hi Vladimir,

Thank you for the patch.

On Friday 07 Jul 2017 05:37:36 Vladimir Barinov wrote:
From: Vladimir Barinov <vladimir.barinov+renesas@xxxxxxxxxxxxxxxxxx>

The ULCB board has one HDMI output connector.

This connector is available on both the H3 and M3-W ULCB boards.
Add this to the ulcb.dtsi file.

Signed-off-by: Vladimir Barinov
<vladimir.barinov+renesas@xxxxxxxxxxxxxxxxxx> ---
  arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi
b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 6f0a7ca..fc5408d 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -34,6 +34,17 @@
  		clock-frequency = <11289600>;
  	};

+	hdmi0-out {
+		compatible = "hdmi-connector";
+		label = "HDMI0 OUT";
As far as I know there is no "HDMI0 OUT" label on the board or casing. You can
remove the label property. Apart from that,
I was thinking that this is a label on schematic.

ULCB has similar schematic label as first HDMI connector on Salvator-X "HDMI output(HDMI0)", hence I've just copied label name from Salvator-X file.

Right, there is no such name on ULCB pcb or plastic cover.

Is it okay If I resend only one patch with label field removed?

Regards,
Vladimir




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux