RE: [RFT] mmc: tmio: fix CMD12 (STOP) handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram-san,

> -----Original Message-----
> From: Wolfram Sang
> Sent: Thursday, July 6, 2017 3:39 PM
> 
> > I and Dung-san are testing this patch.
> > However, this original code doesn't run by our test cases.
> > Do you know how this original code runs?
> > Anyway, we will try to make a test case somehow now.
> 
> Thank you very much, Shimoda-san. I got it tested because a card needed
> re-tuning during a transfer.
> 
> It might work if you manually induce an error bit in the driver
> somewhere. I'll try to find a good sport later, too. However, I am away
> from my boards today and tomorrow.

We tested this patch on H3 Salvator-X.
If we add debug code in this driver (e.g. 400th mmc request assumes an error),
this original code ran and the following message output:
===============
[  258.245349] mmcblk1: mmc1:e624 SU08G 7.40 GiB
[  258.259245]  mmcblk1: p1
[  268.513997] renesas_sdhi_internal_dmac ee100000.sd: timeout waiting 
for hardware interrupt (CMD12)
[  273.633998] renesas_sdhi_internal_dmac ee100000.sd: timeout waiting 
for hardware interrupt (CMD12)
[  278.754000] renesas_sdhi_internal_dmac ee100000.sd: timeout waiting 
for hardware interrupt (CMD12)
[  283.873995] renesas_sdhi_internal_dmac ee100000.sd: timeout waiting 
for hardware interrupt (CMD12)
[  288.994000] renesas_sdhi_internal_dmac ee100000.sd: timeout waiting 
for hardware interrupt (CMD12)
[  289.042012] mmcblk1: error -110 sending stop command
===============

And then, after we applied this patch, no regression happens and the following
message output:
===============
 [   66.433902] mmcblk1: mmc1:e624 SU08G 7.40 GiB
[   66.449161]  mmcblk1: p1
[   66.505322] mmcblk1: error -110 sending stop command
===============

So,

Tested-by: Nguyen Viet Dung <dung.nguyen.aj@xxxxxxxxxxx>

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux