On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund > <niklas.soderlund@xxxxxxxxxxxx> wrote: > >> > Whit all this being said I still like to withdraw this patch as I found > >> > another fault with it, ravb_wol_restore() will unconditionally be called > >> > while ravb_wol_setup() will only be called if netif_running(ndev). This > >> > is en easy fix and I will send out a v2 once we figure out what to do > >> > about the clock. > >> > >> The clock issue is external to the ravb driver. If it works with > >> s2idle, it should > >> be OK. > > > > Do you think it's a good idea to move ahead with a v2 of the ravb WoL > > patch to fix the unrelated issue and aim for it to be picked up prior to > > suspend/resume support is added to the CPG/MSSR? > > Sure. > > It can still be used on R-Car Gen2, where we're not s*d by mandatory PSCI. Is there some way for - e.g. the driver - to not enable WoL on Gen3 SoCs until the clock issues is sorted out? I'm quite happy to enable features where they work; not so much where they don't.
