Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 12, 2017 at 01:00:34PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Friday 12 May 2017 11:16:39 Simon Horman wrote:
> > On Thu, Apr 27, 2017 at 04:37:35PM +0200, Ulrich Hecht wrote:
> > > Hi!
> > > 
> > > Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
> > > boards.
> > > 
> > > This revision addresses the issues found by Geert and adds Laurent's
> > > backlight support patch, including a version for r8a7796.
> > > 
> > > CU
> > > Uli
> > > 
> > > Changes since v1:
> > > - PWM clock is S0D12, not S3D4
> > > - dts: fix register lengths, add resets
> > > - only enable one set of pins for each PWM
> > > - add backlight support
> > > 
> > > Laurent Pinchart (1):
> > >   arm64: dts: r8a7795: salvator-x: Add panel backlight support
> > > 
> > > Ryo Kodama (2):
> > >   clk: renesas: r8a7796: add PWM clock
> > >   arm64: dts: r8a7796-salvator-x: Add PWM device support
> > > 
> > > Takeshi Kihara (3):
> > >   pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
> > >   arm64: dts: r8a7796: Add PWM device nodes
> > >   arm64: dts: r8a7795-salvator-x: Enable PWM2
> > 
> > I did not notice any regressions on salvator-x/r8a7796 after applying up
> > the dts patches without the clk and pinctrl patches. So I have queued up
> > the dts patches as follows:
> > 
> > * arm64: dts: r8a7796: Add PWM device nodes
> >   -> applied
> > 
> > * arm64: dts: r8a7795: salvator-x: Add panel backlight support
> > * arm64: dts: r8a7795-salvator-x: Enable PWM2
> 
> I've asked Ulrich for a clarification on this patch as I'm not sure it's 
> needed, but he hasn't answered yet. Could we delay merging it until the 
> situation is clarified ?

Sure, I will drop the "Enable PWM2" patch.

> All other patches in this series should be fine.
> 
> >   -> applied to salvator-x.dtsi instead of r8a7796-salvator-x.dts
> > 
> > * arm64: dts: r8a7796: salvator-x: Add panel backlight support
> > * arm64: dts: r8a7796-salvator-x: Add PWM device support
> >   -> not applied as they would be the same changes as those above
> >      applied to salvator-x.dtsi
> > 
> > > Ulrich Hecht (2):
> > >   arm64: dts: r8a7796: salvator-x: Add panel backlight support
> > >   dt-bindings: pwm: Add R-Car M3-W device tree bindings
> > 
> > I took the liberty of reposting the dt-bindings patch with an updated To/Cc
> > list.
> > 
> > >  .../devicetree/bindings/pwm/renesas,pwm-rcar.txt   |   1 +
> > >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  34 +++++
> > >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  35 +++++
> > >  arch/arm64/boot/dts/renesas/r8a7796.dtsi           |  70 ++++++++++
> > >  drivers/clk/renesas/r8a7796-cpg-mssr.c             |   1 +
> > >  drivers/pinctrl/sh-pfc/pfc-r8a7796.c               | 153 ++++++++++++++++
> > >  6 files changed, 294 insertions(+)
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux